Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify undefined values for plugin.install #307

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

Imadzuma
Copy link
Contributor

@Imadzuma Imadzuma commented Dec 8, 2022

Description

Added missed check for undefined values

Fixes # (issue)
#300

Solution

Describe solution. List all changes that you made during implementation.
*

How to apply

Provide steps how to apply on top previous Kubemarine version to execute on existing clusters

Test Cases

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

TestCase 1

Test Configuration:

  • Hardware:
  • OS:
  • Inventory:

Steps:

Results:

Before After

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@Imadzuma Imadzuma requested a review from ilia1243 December 8, 2022 12:34
@ilia1243 ilia1243 self-requested a review December 8, 2022 13:58
@koryaga koryaga self-assigned this Dec 9, 2022
@koryaga koryaga merged commit 8eec825 into main Dec 9, 2022
@koryaga koryaga deleted the check-undefined-plugin-install branch December 9, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants